Backport of VAULT-15668: fix windows issues with -dev-tls flag into release/1.13.x #20288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/miagilepner/VAULT-15668-devtls-windows/truly-major-bluegill
branch
from
e9825de
to
9b1b9f1
Compare
miagilepner
approved these changes
Apr 21, 2023
miagilepner
force-pushed
the
backport/miagilepner/VAULT-15668-devtls-windows/truly-major-bluegill
branch
from
9b1b9f1
to
f1ce02e
Compare
miagilepner
deleted the
backport/miagilepner/VAULT-15668-devtls-windows/truly-major-bluegill
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20257 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
The -dev-tls command wasn't working on windows, because the filepaths in the hcl config had unescaped backslashes. This PR adds escaping.
I also tested the changes on a windows VM, and confirmed that they resolved the problem.
Closes #20038
Overview of commits