Add HCP tabs, apply Vale suggestions, fix heading case #20361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codergs
reviewed
Apr 26, 2023
codergs
reviewed
Apr 26, 2023
codergs
reviewed
Apr 26, 2023
yhyakuna
approved these changes
Apr 28, 2023
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
This was referenced May 1, 2023
Closed
yhyakuna
added a commit
that referenced
this pull request
May 1, 2023
* Add HCP tabs, apply Vale suggestions, fix heading case * Apply feedback * Apply PM feedback * Update website/content/docs/secrets/databases/oracle.mdx Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> * Update website/content/docs/secrets/databases/oracle.mdx Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> * Update website/content/docs/secrets/databases/oracle.mdx Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> --------- Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
yhyakuna
added a commit
that referenced
this pull request
May 1, 2023
* Add HCP tabs, apply Vale suggestions, fix heading case * Apply feedback * Apply PM feedback * Update website/content/docs/secrets/databases/oracle.mdx Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> * Update website/content/docs/secrets/databases/oracle.mdx Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> * Update website/content/docs/secrets/databases/oracle.mdx Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> --------- Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
yhyakuna
added a commit
that referenced
this pull request
May 1, 2023
* Add HCP tabs, apply Vale suggestions, fix heading case * Apply feedback * Apply PM feedback * Update website/content/docs/secrets/databases/oracle.mdx * Update website/content/docs/secrets/databases/oracle.mdx * Update website/content/docs/secrets/databases/oracle.mdx --------- Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL 5/1
🔍 Deploy preview
-- I opted for tabs in each section to maintain the right hand navigation based on section headers to stay consistent with other docs in the database secret engine category.