Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Skip TestOcsp_HigherLevel test failures if we are about to trigger the redirection bug into release/1.13.x #20463

Merged
merged 1 commit into from
May 2, 2023
Merged

Backport of Skip TestOcsp_HigherLevel test failures if we are about to trigger the redirection bug into release/1.13.x #20463

merged 1 commit into from
May 2, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #20461 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.

  • We have a known issue that is difficult to address in released versions of Vault that OCSP GET requests can contain consecutive / characters which the Golang HTTP mux will force a redirection.
  • Instead of failing various PRs and runs with this known issue, check to see if we are about to trigger it and if so skip the test. We have already at this point tested the POST version of the API.
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/skip-ocsp-higherlevel-test/severely-enabled-snipe branch from d5bff4b to 1829829 Compare May 2, 2023 14:44
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/skip-ocsp-higherlevel-test/severely-enabled-snipe branch from 42d4a4c to dc4049f Compare May 2, 2023 14:44
@stevendpclark stevendpclark self-assigned this May 2, 2023
@stevendpclark stevendpclark enabled auto-merge (squash) May 2, 2023 14:49
@stevendpclark stevendpclark added this to the 1.13.3 milestone May 2, 2023
@stevendpclark stevendpclark merged commit 05ceaaf into release/1.13.x May 2, 2023
@stevendpclark stevendpclark deleted the backport/stevendpclark/skip-ocsp-higherlevel-test/severely-enabled-snipe branch May 2, 2023 15:13
@fopina-ci fopina-ci mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark stevendpclark approved these changes

Assignees

@stevendpclark stevendpclark

Labels
pr/no-changelog
Projects
None yet
Milestone
1.13.3
Development

Successfully merging this pull request may close these issues.
2 participants
@hc-github-team-secure-vault-core @stevendpclark