Backport of CLI to take days as a unit of time into release/1.13.x #20514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/fix-ttl-flad-for-day-durations/sadly-quick-dolphin
branch
from
da7618a
to
6087a38
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/fix-ttl-flad-for-day-durations/sadly-quick-dolphin
branch
from
d8aad86
to
fb877fd
Compare
hghaf099
approved these changes
May 4, 2023
hghaf099
deleted the
backport/fix-ttl-flad-for-day-durations/sadly-quick-dolphin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20477 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
For an example:
vault token create -policy=mypolicy -ttl=1dfails with error:
invalid value "1d" for flag -ttl: time: unknown unit "ds" in duration "1ds"Currently, the CLI uses
time.ParseDuration(appendDurationSuffix(s))instead ofparseutil.ParseDurationSecond(s). The fix is to use the latter instead.Addresses #19815
Overview of commits