Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of disable printing flags warning message for the ssh command into release/1.12.x #20542

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #20502 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@hghaf099
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Addresses #19785

Echoing what @maxb has mentioned in the ticket:

The vault ssh command has the unusual purpose of being a wrapper that invokes the real ssh command (after obtaining credentials). 
Moreover, the ssh command can take another command on its command line, to run on the remote machine. 
Because of this, there are multiple ways in which it can be a normal use-case for there to be option-like arguments later in the command line, 
which are deliberately intended either for ssh, or for a command being run via ssh on the remote machine.

This is quite unlike most other commands, where option-like things occurring after positional arguments are often a mistake.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ssh-command-disable-flag-warning-message/awfully-alive-lizard branch from 8e96ea1 to 52de7f5 Compare May 8, 2023 16:16
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ssh-command-disable-flag-warning-message/awfully-alive-lizard branch from 52de7f5 to 8e96ea1 Compare May 8, 2023 16:16
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@hghaf099
Copy link
Contributor

hghaf099 commented May 8, 2023

closing in favour of #20544

@hghaf099 hghaf099 closed this May 8, 2023
@hghaf099 hghaf099 deleted the backport/ssh-command-disable-flag-warning-message/awfully-alive-lizard branch May 8, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants