Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of disable printing flags warning message for the ssh command into release/1.13.x #20543

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #20502 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.


Addresses #19785

Echoing what @maxb has mentioned in the ticket:

The vault ssh command has the unusual purpose of being a wrapper that invokes the real ssh command (after obtaining credentials). 
Moreover, the ssh command can take another command on its command line, to run on the remote machine. 
Because of this, there are multiple ways in which it can be a normal use-case for there to be option-like arguments later in the command line, 
which are deliberately intended either for ssh, or for a command being run via ssh on the remote machine.

This is quite unlike most other commands, where option-like things occurring after positional arguments are often a mistake.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ssh-command-disable-flag-warning-message/actually-pleased-lemur branch from 6a1e24e to 3f9fc4b Compare May 8, 2023 16:16
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ssh-command-disable-flag-warning-message/actually-pleased-lemur branch from 5fba545 to b450d57 Compare May 8, 2023 16:16
@hghaf099 hghaf099 merged commit a6c5b15 into release/1.13.x May 8, 2023
@hghaf099 hghaf099 deleted the backport/ssh-command-disable-flag-warning-message/actually-pleased-lemur branch May 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants