Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky filtering test #20605

Merged
merged 2 commits into from
May 16, 2023
Merged

Fix flaky filtering test #20605

merged 2 commits into from
May 16, 2023

Conversation

Monkeychip
Copy link
Contributor

When running the full test suite I'm battling more than one secret engine and the filtering by name and selecting the first object does not reliably return the same secret engine each time. While ideally I could select by option name, I wasn't able to do that so I am filtering by the first item in the list, confirming one is returned and that it matches the name of the filtered item.

@Monkeychip Monkeychip marked this pull request as ready for review May 16, 2023 18:53
@Monkeychip Monkeychip enabled auto-merge (squash) May 16, 2023 19:34
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the quick turnaround!

@Monkeychip Monkeychip merged commit ba1633f into main May 16, 2023
@hashishaw hashishaw deleted the ui/fix-filtering-test branch May 16, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants