Add client_type field to EntityRecord protobuf #20626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
cipherboy-start-billing-acme
branch
2 times, most recently
from
c75dc21
to
0c402e5
Compare
mpalmi
force-pushed
the
acme-entityrecord-field
branch
2 times, most recently
from
afa6dcb
to
8889e7a
Compare
mpalmi
requested review from
raskchanky,
banks,
cipherboy,
miagilepner,
hghaf099 and
akshya96
|
Still needs a changelog entry and tests (on enterprise) to validate the ClientType field in EntityRecords. |
miagilepner
approved these changes
May 19, 2023
mpalmi
changed the title
mpalmi
force-pushed
the
acme-entityrecord-field
branch
from
b4ff662
to
3cd7ba0
Compare
raskchanky
approved these changes
May 19, 2023
mpalmi
force-pushed
the
acme-entityrecord-field
branch
from
3cd7ba0
to
a46049d
Compare
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new protobuf entry for ClientType. This gets properly populated in
AddActivityToFragmentusing the activityType field (currently "entity", "non-entity-token", or "acme"). Tests to come on the enterprise side.