Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transit import command work for the transform backend #20668

Merged
merged 2 commits into from
May 25, 2023

Conversation

DeLuci
Copy link
Contributor

@DeLuci DeLuci commented May 18, 2023

No description provided.

@DeLuci DeLuci added this to the 1.13.3 milestone May 18, 2023
@DeLuci DeLuci requested review from victorr and a team May 18, 2023 20:45
@hashicorp-cla
Copy link

hashicorp-cla commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

command/transit_import_key.go Outdated Show resolved Hide resolved
@DeLuci DeLuci force-pushed the DeLuci/vault-14652-fix-transit-import branch from 46e793f to 79f72d6 Compare May 25, 2023 17:23
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@DeLuci DeLuci requested a review from sgmiller May 25, 2023 17:29
@DeLuci DeLuci enabled auto-merge (squash) May 25, 2023 20:02
@DeLuci DeLuci disabled auto-merge May 25, 2023 20:04
Copy link
Contributor

@sgmiller sgmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

return path, apiPath, nil
}

type ImportKeyFunc func(s string, operation string) (path string, apiPath string, err error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice abstraction!

@victorr
Copy link
Contributor

victorr commented May 26, 2023

The vault-enterprise PR for this changes is: https://github.com/hashicorp/vault-enterprise/pull/4075

That PR adds unit tests for the new commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants