Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in PKI's runUnifiedTransfer #20701

Merged
merged 2 commits into from
May 22, 2023
Merged

Fix race in PKI's runUnifiedTransfer #20701

merged 2 commits into from
May 22, 2023

Commits on May 22, 2023

  1. Fix race in PKI's runUnifiedTransfer 

    During this race, we'll sometimes start (or fail to start) an additional
unified transfer if the updated last run timestamp was written at the
same time as another thread was reading it.

Instead, delay this check until we're holding the CAS guard; this will
occasionally result in more messages saying that an existing process is
already running, but otherwise shouldn't impact the functionality at
all.

Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed May 22, 2023
    Configuration menu
    Copy the full SHA
    268cdec View commit details
    Browse the repository at this point in the history

  2. Add changelog entry 

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    @cipherboy
    cipherboy committed May 22, 2023
    Configuration menu
    Copy the full SHA
    b716c05 View commit details
    Browse the repository at this point in the history