VAULT-15395: Support mocking time functions in the activity log #20720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miagilepner
requested review from
mpalmi,
raskchanky,
banks,
hghaf099 and
akshya96
mpalmi
approved these changes
May 23, 2023
hghaf099
reviewed
May 23, 2023
hghaf099
reviewed
May 23, 2023
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an exported interface to the timeutil package called
Clock, which can be used to mock the standard lib time functions.I've used the interface in the activity log, so that tests can configure mocked time functions. I added a test that uses this functionality to mock the end of a month.