Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Test-ui suite failure for package install issues #20756

Merged
merged 4 commits into from
May 24, 2023
Merged

Address Test-ui suite failure for package install issues #20756

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
466e796
fix
Monkeychip May 24, 2023
ed698b0
apparently its going to take me two commits.. for one line.
Monkeychip May 24, 2023
c263741
test removing the installation of the packages.
Monkeychip May 24, 2023
9188576
remove browser dependencies
Monkeychip May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ jobs:
node-version-file: './ui/package.json'
cache: yarn
cache-dependency-path: ui/yarn.lock
- id: install-browser-libraries
run: sudo apt install -y libnss3-dev libgdk-pixbuf2.0-dev libgtk-3-dev libxss-dev libasound2
# - id: install-browser-libraries
# run: sudo apt update && sudo apt install -y libnss3-dev libgdk-pixbuf2.0-dev libgtk-3-dev libxss-dev libasound2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, I'll remove 230-231, just doing a test.

- id: install-browser
uses: browser-actions/setup-chrome@c485fa3bab6be59dce18dbc18ef6ab7cbc8ff5f1 # v1.2.0
- id: ui-dependencies
Expand Down