Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.12.x: Backport TTL picker changes #20792

Merged
merged 3 commits into from
May 26, 2023

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented May 25, 2023

A regression bug occurred in 1.12 and 1.11 on the TTL picker, but they appeared fixed in 1.13. Backporting the 1.13 PR that fixed the issues to 1.12 and 1.11.

Bug was evident in AWS secret engine, configuration, leases, set the TTL and it would set in minutes and not seconds as shown on the picker.

@Monkeychip Monkeychip added this to the 1.12.7 milestone May 25, 2023
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Monkeychip Monkeychip merged commit 439c904 into release/1.12.x May 26, 2023
@Monkeychip Monkeychip deleted the ui/backport-pr-18114-1.12.x-2 branch May 26, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants