Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI cluster unseal bug #20897

Merged
merged 2 commits into from
May 31, 2023
Merged

UI cluster unseal bug #20897

merged 2 commits into from
May 31, 2023

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented May 31, 2023

It was discovered that the secret_shares and secret_threshold properties are no longer allowed to be passed when unsealing a cloud seal type cluster. These properties were being passed in the UI causing the unseal to fail. Removing these properties from the payload for seal types other than shamir allows the cluster to be unsealed as expected.

Error before fix:
image

After fix:

Screen.Recording.2023-05-31.at.2.16.46.PM.mov

Resolves #20644

@zofskeez zofskeez added ui bug Used to indicate a potential bug labels May 31, 2023
@zofskeez zofskeez added this to the 1.14 milestone May 31, 2023
@zofskeez zofskeez changed the title UI cluser unseal bug UI cluster unseal bug May 31, 2023
@zofskeez zofskeez modified the milestones: 1.14, 1.12.7 May 31, 2023
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job tracking this down! 🕵️ And lovely test coverage ⭐

@zofskeez zofskeez merged commit 0defa2a into main May 31, 2023
@zofskeez zofskeez deleted the ui/VAULT-16511/auto-unseal-bug branch May 31, 2023 20:21
zofskeez added a commit that referenced this pull request May 31, 2023
* fixes issue unsealing cloud seal type cluster

* adds changelog entry
zofskeez added a commit that referenced this pull request May 31, 2023
* fixes issue unsealing cloud seal type cluster

* adds changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't init 1.13.2 with awskms
2 participants