Generate ACME EAB tokens that do not start with '-' #20945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
Jun 1, 2023
stevendpclark
commented
- To avoid people having issues copying EAB tokens and using them on command lines when they start with - from the base64 encoded values, append a prefix.
- Remove the key_bits data from the eab api, not really useful and now technically wrong
- Fix up some issues with tests not running in parallel.
- Update docs to reflect new EAB apis.
cipherboy
reviewed
Jun 1, 2023
- To avoid people having issues copying EAB tokens and using them on command lines when they start with - from the base64 encoded values, append a prefix. - Remove the key_bits data from the eab api, not really useful and now technically wrong - Fix up some issues with tests not running in parallel. - Update docs to reflect new EAB apis.
stevendpclark
force-pushed
the
stevendpclark/vault-16836-prefix-eab-tokens
branch
from
77504a6
to
ab350e2
Compare
cipherboy
approved these changes
Jun 5, 2023
- Our decoded prefix was not divisable by 3, which meant the last character might be tweaked by the rest of the input
cipherboy
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.