Backport of openapi: Fix generated types for duration strings into release/1.14.x #21000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/fix-openapi-duration-format/frequently-communal-stinkbug
branch
2 times, most recently
from
3bd1bcb
to
1910293
Compare
averche
approved these changes
Jun 26, 2023
…at/frequently-communal-stinkbug
VioletHynes
added
the
hashicorp-contributed-pr
schavis
added
the
vault-update
|
@averche do you happen to know if this should be merged or closed? |
averche
deleted the
backport/fix-openapi-duration-format/frequently-communal-stinkbug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20841 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
Duration are sent as strings today (e.g.
"10s","20m", etc.), which breaks the code generated based on the current OpenAPI spec which encodes them as integers. This small fix addresses the issue.Overview of commits