ui: part 4 final cleanup #21365
Merged
ui: part 4 final cleanup #21365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
commented
Jun 20, 2023
| @close={{close}} | ||
| @isPreformatted={{flash.preformatted}} | ||
| /> | ||
| {{#let (hash info="highlight" success="success" danger="critical" warning="warning") as |color|}} |
There was a problem hiding this comment.
I opted to do this in the hbs template instead of making an external helper since I didn't see a need for these mappings to be used elsewhere once we transition completely to using HDS components. For example, AlertInline should eventually have @type="danger" updated to @type="critical" to match HDS language.
But would love some feedback here!
There was a problem hiding this comment.
I think it makes sense to do this in the template for now :)
hellobontempo
commented
Jun 20, 2023
| This test string matches the pattern regex. | ||
| </p> | ||
| </div> | ||
| <AlertInline |
kiannaquach
reviewed
Jun 20, 2023
| @@ -11,14 +11,4 @@ | |||
| position: fixed; | |||
| width: 95%; | |||
| z-index: 300; | |||
|
|
|||
There was a problem hiding this comment.
i appreciate that you're also removing the css associated with the old alert banners!
kiannaquach
approved these changes
Jun 20, 2023
hellobontempo
merged commit 3911cc2
into
ui/VAULT-16910/hds-adoption-replace-AlertBanner
hellobontempo
added a commit
that referenced
this pull request
Jun 21, 2023
* UI: HDS adoption replace AlertBanner part 1 (#21163) * rename test selector * replace db banner * add class * replace db role edit * db creds * generate creds * simpler class * license banner component * oidc callback plash * raft * aws * secret create or update * change to compact alert for form field * change back to inline * combine alert banners * wrap in conditional * remove references to message class * UI: HDS adoption replace AlertBanner part 2 (#21243) * token expire warning * delete css * edit form * item details distribute mfa step 2 transit verify * back to secondary * distribute * oidc lease error * sign * kv obj and repl dash * more repl * update test selector * show, creds * shamir * pki csr * pki banners * add hds library to ember engines * woops comma * fix k8 test * update message error component for last! * hold off MessageError changes until next pr * revert test selectors * update pki tests * UI: part 3 remove alert banner (#21334) * final component swap * and actual final of MessageError * update MessageError selectors * delete alert-banner and remove references * update next step alerts to highlight color * finishing touches, auth form test and client dashboard inline link * fix more selectors * fix shamir flow test * ui: part 4 final cleanup (#21365) * replace AlertPopup * add test tag * move tag * one more message error tag * delete alert popup * final css cleanup * move preformatted flash into <p> tag * ui: address comments for sidebranch (#21388) * add periods, move link to trailing * more periods and typo fix
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flash message comparisons new + old
purple highlight for info
wrapping of really long item names
applying
white-space: pre-wrapclass