Update packages and OpenApi styling #23700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
hashishaw
approved these changes
Oct 24, 2023
…/hashicorp/vault into ui/VAULT-21121/outdated-packages
…/hashicorp/vault into ui/VAULT-21121/outdated-packages
zofskeez
approved these changes
Oct 24, 2023
Co-authored-by: Jordan Reimer <zofskeez@gmail.com>
…/hashicorp/vault into ui/VAULT-21121/outdated-packages
This was referenced Oct 25, 2023
Monkeychip
added a commit
that referenced
this pull request
Oct 25, 2023
* update packages * changelog * wip better * clean up * and it works, it always worked we just hid it working :/ * clean up * playing around with adding the queryparam, not working * the fix no queryparams * lets just see how this works out. * maybe this will help * remove copy/pasta * Update ui/lib/open-api-explorer/addon/components/swagger-ui.js Co-authored-by: Jordan Reimer <zofskeez@gmail.com> --------- Co-authored-by: Jordan Reimer <zofskeez@gmail.com>
Monkeychip
added a commit
that referenced
this pull request
Oct 26, 2023
* Update packages and OpenApi styling (#23700) * update packages * changelog * wip better * clean up * and it works, it always worked we just hid it working :/ * clean up * playing around with adding the queryparam, not working * the fix no queryparams * lets just see how this works out. * maybe this will help * remove copy/pasta * Update ui/lib/open-api-explorer/addon/components/swagger-ui.js Co-authored-by: Jordan Reimer <zofskeez@gmail.com> --------- Co-authored-by: Jordan Reimer <zofskeez@gmail.com> * Update swagger-ui-test.js --------- Co-authored-by: Jordan Reimer <zofskeez@gmail.com>
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates packages that needed addressing after running
yarn npm audit.For the package
swagger-ui-dist, the update broke the CSS. It did this by wrapping elements in buttons, changing the elements nesting structure, and replacing spans with divs. After some consideration, I decided on doing the following:Edit: It also broke the filtering functionality because of a React update behind the scenes. I decided it was cleaner, easier, less bug prone to use Swagger's filtering input. See the updated screenshot for how this looks. This also means queryParam for URL sharing is no long available.
Old OpenAPI view
After update
