-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip unnecessary deriving of policies from entity on Login MFA check #23894
Merged
davidadeleon
merged 5 commits into
main
from
davidadeleon/skip-derive-entity-policies-for-mfa-check
Oct 31, 2023
Merged
Skip unnecessary deriving of policies from entity on Login MFA check #23894
davidadeleon
merged 5 commits into
main
from
davidadeleon/skip-derive-entity-policies-for-mfa-check
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Oct 28, 2023
Build Results: |
CI Results: |
ncabatoff
approved these changes
Oct 30, 2023
raskchanky
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
davidadeleon
deleted the
davidadeleon/skip-derive-entity-policies-for-mfa-check
branch
October 31, 2023 14:15
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips the unnecessary deriving of policies from a fetched entity. The returned policies are ignored so we can safely skip doing the work here.