Fix listing of deep paths in PostgreSQL backend #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckarenz
force-pushed
the
fix-psql-list
branch
2 times, most recently
from
a66159d
to
5dd4f0a
Compare
This change addresses an issue where deep paths would not be enumerated if parent paths did not contain a key. Given the keys `shallow` and `deep` at the following paths... ``` secret/shallow secret/path/deep ``` ... a `LIST` request against `/v1/secret` would produce only one result, `shallow`. With this change, the same list request will now list `shallow` and `path/`.
ckarenz
force-pushed
the
fix-psql-list
branch
from
5dd4f0a
to
16fa3dd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue where deep paths would not be enumerated if parent paths did not contain a key.
Given the keys
shallowanddeepat the following paths...... a
LISTrequest against/v1/secretwould produce only one result,path1/. With this change, the same list request will now listpath1/andpath2/.