Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle expired OCSP responses from server #24193

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Handle expired OCSP responses from server #24193

merged 2 commits into from
Nov 20, 2023

Conversation

stevendpclark
Copy link
Contributor

  • If a server replies with what we considered an expired OCSP response, NextUpdate is now or in the past, and it was our only response we would panic due to missing error handling logic.

@stevendpclark
Handle expired OCSP responses from server
2d967ee 
 - If a server replied with what we considered an expired OCSP response (nextUpdate is now or in the past), and it was our only response we would panic due to missing error handling logic.
@stevendpclark stevendpclark added bug Used to indicate a potential bug auth/cert Authentication - certificates backport/1.13.x labels Nov 20, 2023
@stevendpclark stevendpclark added this to the 1.13.11 milestone Nov 20, 2023
@stevendpclark stevendpclark self-assigned this Nov 20, 2023
@stevendpclark stevendpclark requested a review from a team as a code owner November 20, 2023 14:56
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 20, 2023
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

victorr
victorr approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@kitography kitography self-requested a review November 20, 2023 15:32
kitography
kitography approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@kitography kitography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevendpclark stevendpclark merged commit bcbd45b into main Nov 20, 2023
109 checks passed
@stevendpclark stevendpclark deleted the stevendpclark/vault-22019-certauth-ocsp-panic branch November 20, 2023 15:51
This was referenced Nov 20, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorr victorr victorr approved these changes

@kitography kitography kitography approved these changes

Assignees

@stevendpclark stevendpclark

Labels
auth/cert Authentication - certificates bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.13.11
Development

Successfully merging this pull request may close these issues.
3 participants
@stevendpclark @victorr @kitography