VAULT-23121: Audit - Empty fields are HMAC and appear in audit logs #24901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds to appear HMAC in audit logs
peteski22
added
core
peteski22
changed the title
|
CI Results: failed ❌
|
|
Build Results: |
…/audit-hmac-empty-values
|
This one has a do-not-merge label and still has not been reviewed so I will move this to the 1.16.1 milestone since today is code freeze. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had reports where customers see a different output structure in their audit logs depending on whether they are using
log_rawoption or not.When raw output is enabled, empty fields which have been marked to be omitted from JSON output are honored, however when HMAC is applied, the empty fields first have HMAC applied and then are JSON encoded meaning they're never empty and always appear.
This PR updates
GetIdentifiedHMACto ignore default string value ("") which causes some fields to appear in the audit logs with a HMAC'd value for"".