-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Update resultant-acl banner #25256
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a86671f
Request resultant-acl only from users root namespace
hashishaw a613bfd
Update permissions adapter to always call resultant-acl at users root…
hashishaw 472c7ca
Update resultant-acl to accept failType
hashishaw 8d692a1
Update permissions service to set permissionsBanner based on resultan…
hashishaw 160f9d9
wire it up
hashishaw 3a8bca6
add changelog
hashishaw 8aad2f1
Merge branch 'main' into ui/VAULT-23578/resultant-acl-fix
hashishaw a83f3da
cleanup unused adapter changes
hashishaw 457e672
use getter for shared namespace logic
hashishaw bec3156
Merge branch 'main' into ui/VAULT-23578/resultant-acl-fix
hashishaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:bug | ||
ui: Do not show resultant-acl banner on namespaces a user has access to | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/** | ||
* Copyright (c) HashiCorp, Inc. | ||
* SPDX-License-Identifier: BUSL-1.1 | ||
*/ | ||
|
||
import { module, test } from 'qunit'; | ||
import { setupTest } from 'ember-qunit'; | ||
import { setupMirage } from 'ember-cli-mirage/test-support'; | ||
|
||
module('Unit | Adapter | permissions', function (hooks) { | ||
setupTest(hooks); | ||
setupMirage(hooks); | ||
|
||
test('it calls resultant-acl with the users root namespace', async function (assert) { | ||
assert.expect(1); | ||
const adapter = this.owner.lookup('adapter:permissions'); | ||
const nsService = this.owner.lookup('service:namespace'); | ||
nsService.setNamespace('admin/foo'); | ||
nsService.reopen({ | ||
userRootNamespace: 'admin/bar', | ||
}); | ||
this.server.get('/sys/internal/ui/resultant-acl', (schema, request) => { | ||
assert.strictEqual( | ||
request.requestHeaders['X-Vault-Namespace'], | ||
'admin/bar', | ||
'Namespace is users root not current path' | ||
); | ||
return { | ||
data: { | ||
exact_paths: {}, | ||
glob_paths: {}, | ||
}, | ||
}; | ||
}); | ||
await adapter.query(); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For someone not super familiar with this response, could you maybe add a comment with an example of glob vs exact paths? Especially since the API doc are 🙃 in information for this endpoint. Found this stackoverflow with someones examples to help me visual it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the best example is in the test file
I'd love to make this service glimmer + typescript, but since this change will be backported that will have to be a follow on