Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing vault.audit.log_response_failure metric doc #26038

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

gerardma77
Copy link
Contributor

Screenshot 2024-03-19 at 17 42 49

I've changed the description for the vault.audit.log_response_failure metric from:
Number of audit log request failures across all devices
into:
Number of audit log response failures across all devices

I've changed the explanation from:

A non-zero value for vault.audit.log_response_failure indicates that one of the configured audit log devices failed to respond to Vault. If Vault cannot properly audit a request, or the response to a request, the original request will fail.
into:
A non-zero value for vault.audit.log_response_failure indicates that all of the configured audit log devices failed to respond to Vault. If Vault cannot properly audit a request, or the response to a request, the original request will fail.

@gerardma77 gerardma77 added docs website Code changes specifically for the docs website pr/no-changelog backport/1.15.x labels Mar 19, 2024
@gerardma77 gerardma77 requested a review from a team as a code owner March 19, 2024 16:48
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 19, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@gerardma77 gerardma77 changed the title changing log_response_failure metric doc changing vault.audit.log_response_failure metric doc Mar 19, 2024
…ponse_failure.mdx

Co-authored-by: Kuba Wieczorek <kuba.wieczorek@hashicorp.com>
@schavis schavis merged commit d9b840c into main Mar 25, 2024
34 of 35 checks passed
@schavis schavis deleted the docs/audit-doc-update branch March 25, 2024 21:16
schavis pushed a commit that referenced this pull request May 3, 2024
* changing log_response_failure metric doc

* Update website/content/partials/telemetry-metrics/vault/audit/log_response_failure.mdx

Co-authored-by: Kuba Wieczorek <kuba.wieczorek@hashicorp.com>

---------

Co-authored-by: Kuba Wieczorek <kuba.wieczorek@hashicorp.com>
schavis added a commit that referenced this pull request May 8, 2024
…26800)

* Fix "auto unseal" case inconsistency (#25119)

There was inconsistency in the capitalization of auto unseal in this doc.  The initial heading had it right. It shouldn't be capitalized according to the documentation style guidance for feature capitalization. Also, high availability doesn't need to be capitalized.

Change warning to tag syntax so it's clear what should be part of the aside

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update events.mdx (#25835)

Added missing ' to the command at the end

* changing vault.audit.log_response_failure metric doc (#26038)

* changing log_response_failure metric doc

* Update website/content/partials/telemetry-metrics/vault/audit/log_response_failure.mdx

Co-authored-by: Kuba Wieczorek <kuba.wieczorek@hashicorp.com>

---------

Co-authored-by: Kuba Wieczorek <kuba.wieczorek@hashicorp.com>

* Documentation: WAF: add merkle-check documentation (#25743)

* Documentation: WAF: add merkle-check documentation

- Update Enterprise / Replication navigation
- Move Replication page to Overview
- Add Check for Merkle tree corruption page

* Update website/content/docs/enterprise/replication/check-merkle-tree-corruption.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/enterprise/replication/check-merkle-tree-corruption.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/enterprise/replication/check-merkle-tree-corruption.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/enterprise/replication/check-merkle-tree-corruption.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

---------

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
Co-authored-by: CJ <105300705+cjobermaier@users.noreply.github.com>

---------

Co-authored-by: Mitch Pronschinske <mpronschinske@hashicorp.com>
Co-authored-by: preetibhat6 <139800125+preetibhat6@users.noreply.github.com>
Co-authored-by: gerardma77 <115136373+gerardma77@users.noreply.github.com>
Co-authored-by: Kuba Wieczorek <kuba.wieczorek@hashicorp.com>
Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>
Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
Co-authored-by: CJ <105300705+cjobermaier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone website Code changes specifically for the docs website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants