Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity-alias): return metadata when listing entity-aliases #26073

Conversation

pree
Copy link
Contributor

@pree pree commented Mar 21, 2024

Returns not only the custom_metadata but also the metadata which might be set by an OIDC provider on entity aliases.
This helps especially when you need to search for a user using the metadata on an entity-alias, as the alias-id should be a unique identifier, that might not be an email address etc.

$ vault list -detailed identity/entity-alias/id

Keys                                    canonical_id                            custom_metadata         local    metadata                 mount_accessor            mount_path        mount_type    name
----                                    ------------                            ---------------         -----    --------                 --------------            ----------        ----------    ----
bd991d20-5934-278a-edd2-272857fb8776    a3b0505d-75cb-bb87-c1b0-8cc4bcb169f1    <nil>                   false    map[username:pree]       auth_oidc_a44c8eff        auth/oidc/        oidc          165fc151-fbff-42a2-890f-a7b2014f8f28

Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for this. I've just added a changelog and I think this looks like a good addition.

I appreciate the example given and the motivation for the change sounds solid. Assuming CI passes I'll try and merge this in. I appreciate your patience in waiting for a review for this.

@VioletHynes VioletHynes merged commit 9f5371d into hashicorp:main Jun 6, 2024
66 of 67 checks passed
@pree pree deleted the feat/add-metadata-to-detailed-entity-alias-list branch June 6, 2024 19:49
@pree
Copy link
Contributor Author

pree commented Jun 6, 2024

Thanks @VioletHynes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants