VAULT-24945: audit - add context timeout to audit request #26616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
core/audit
hashicorp-contributed-pr
|
CI Results: |
added 3 commits
April 30, 2024 11:09
|
Build Results: |
ccapurso
approved these changes
Apr 30, 2024
Comment on lines
+463
to
+469
| // isContextViable examines the supplied context to see if its own deadline would | ||
| // occur later than a newly created context with a specific timeout. | ||
| // If the existing context is viable it can be used 'as-is', if not, the caller | ||
| // should consider creating a new context with the relevant deadline and associated | ||
| // context values (e.g. namespace) in order to reduce the likelihood that the | ||
| // audit system believes there is a failure in audit (and updating its metrics) | ||
| // when the root cause is elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per: #24238, but for auditing requests.
This PR updates the logic used for request and response to check whether the existing context would suffice.