UI: rearrange logic for adding timezone in date-format helper #26693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
hellobontempo
commented
Apr 30, 2024
| let zone; // local timezone ex: 'PST' | ||
| try { | ||
| // passing undefined means default to the browser's locale | ||
| zone = ' ' + date.toLocaleTimeString(undefined, { timeZoneName: 'short' }).split(' ')[2]; |
There was a problem hiding this comment.
removed the space here so if toLocaleTimeString doesn't error but returns undefined again in the future for some reason, zone will be falsey
hashishaw
approved these changes
Apr 30, 2024
|
|
||
| const formatted = formatTimeZone(TEST_DATE); | ||
|
|
||
| assert.strictEqual( |
There was a problem hiding this comment.
Maybe we add one more assertion, since the expected value is computed, that makes sure the zone is NOT undefined
There was a problem hiding this comment.
Yeah! Good call ⚡
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to reproduce this issue. I downloaded Brave and set my system timezone to GMT+1. I was not able to download the older version of Brave, but at least on newer versions this is no longer an issue. I updated the logic regardless so undefined timezones won't be displayed
