Bump backoff/v3 to backoff/v4 #26868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
|
Hey @crazybolillo ! I'm interested in getting this merged. I just tested this a little locally and it doesn't look like it breaks anything. Before we can do that, it looks like there's some merge conflicts. Would it be possible for you to resolve them? Once those get resolved, I'd be happy to approve and merge this in. |
This makes it so projects that are already using backoff don't need to pull up an old version of it just because of vault/api. This major version change is compatible with existing usage in code. Refs hashicorp#24707.
|
Thanks, I have rebased the MR and fixed the conflicts. |
VioletHynes
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so projects that are already using backoff don't need to pull up an old version of it just because of vault/api. This major version change is compatible with existing usage in code.
Refs #24707.