Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address a11y issues in browser-based console UI #26872

Merged
merged 18 commits into from
May 16, 2024
Merged

Address a11y issues in browser-based console UI #26872

merged 18 commits into from
May 16, 2024

Commits on May 16, 2024

  1. VAULT-26829

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3fc63ae View commit details
    Browse the repository at this point in the history

  2. associate input and help text

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    bce5995 View commit details
    Browse the repository at this point in the history

  3. Add ESC key support

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c128021 View commit details
    Browse the repository at this point in the history

  4. adjust console-ui panel for text-spacing requirement 

    Added console focus trap

Added else conditional for console-panel

update aria-label for input

reverting height style change

reverting focus trap for now

fixed typo

re-adding focus trap to console::uiPanel component

refactor conditional yield of console ui panel

remove duplicated option for ui panel

move ESC command to focus-trap

change focus-trap to use onDeactivate
    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b3d5706 View commit details
    Browse the repository at this point in the history

  5. fix test to toggle panel open before using it 

    move toggle to commands helper file

move toggle to ui-panel helper file

added shouldToggle arg to runcommand

fix console tests
    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    36256da View commit details
    Browse the repository at this point in the history

  6. add changelog

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    425cc5b View commit details
    Browse the repository at this point in the history

  7. Update ui/app/components/console/ui-panel.js 

    remove unnecessary comment
    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4bb5705 View commit details
    Browse the repository at this point in the history

  8. Update test to try to get it to pass

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    bf26929 View commit details
    Browse the repository at this point in the history

  9. add support for console dismiss button

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b319d10 View commit details
    Browse the repository at this point in the history

  10. updates to command helper for toggling console

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a4f5409 View commit details
    Browse the repository at this point in the history

  11. Adjusted code so tests pass

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8bbb24a View commit details
    Browse the repository at this point in the history

  12. Fixed one of the failing tests (one is still failing)

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6b39201 View commit details
    Browse the repository at this point in the history

  13. Adjusted code so tests pass

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5977177 View commit details
    Browse the repository at this point in the history

  14. Adjusted code to fix test

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7525254 View commit details
    Browse the repository at this point in the history

  15. Added additional changelog text

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    30f9edc View commit details
    Browse the repository at this point in the history

  16. Update changelog/26872.txt 

    Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com>
    @MelSumner @hashishaw
    MelSumner and hashishaw committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a5b2076 View commit details
    Browse the repository at this point in the history

  17. Update ui/tests/acceptance/oidc-provider-test.js

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5029cf1 View commit details
    Browse the repository at this point in the history

  18. remove errant code

    @MelSumner
    MelSumner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b9d6b0c View commit details
    Browse the repository at this point in the history