Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license file to Dockerfile as per legal requirement #27154

Merged
merged 2 commits into from
May 22, 2024

Conversation

biazmoreira
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 21, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Collaborator

@sarahethompson sarahethompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! might be worth putting a comment in the file that this update shouldn't be made in ent. I had a look at the COPY LICENSE /licenses/mozilla.txt and the reason why this was in there before. It looks like RedHat have strict guidelines on there being a license in a licenses directory. I think it would be best to keep this line but change it to - COPY LICENSE /licenses/LICENSE.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants