Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: remove current_billing_period from dashboard activity log request #27559

Merged

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Jun 20, 2024

Description

The sys/internal/counters/activity response now defaults to use the license start time to the current month as start and end time params (previously the start_time was the current month minus one year and end_time was the month before current. For example, if it's currently June 2024, the data returned would be from June 2023-May 2024.)

As a result, current_billing_period is now deprecated so we can remove this query param from the dashboard request to the activity log.

✅ enterprise tests

@hellobontempo hellobontempo added this to the 1.18.0-rc milestone Jun 20, 2024
@hellobontempo hellobontempo requested a review from a team as a code owner June 20, 2024 23:11
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 20, 2024
@hellobontempo hellobontempo changed the title UI: remove current_billing_period from dashboard request UI: remove current_billing_period from dashboard activity log request Jun 20, 2024
Copy link

github-actions bot commented Jun 20, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jun 20, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hellobontempo hellobontempo merged commit 6f00ce4 into main Jun 21, 2024
31 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-28312/remove-current_billing_period-from-dashboar branch June 21, 2024 18:06
hashishaw added a commit that referenced this pull request Sep 17, 2024
…st (#27559)

* remove current_billing_period from dashboard request

* add changelog

* remove timestamp from assertion

* update mirage
hashishaw added a commit that referenced this pull request Sep 17, 2024
* Hide flash warning on dashboard from client count activity endpoint

* UI: remove `current_billing_period` from dashboard activity log request (#27559)

* remove current_billing_period from dashboard request

* add changelog

* remove timestamp from assertion

* update mirage

* fix chroot test error 'must setup rendering context before attempting to interact with elements'

* stabilize chroot test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants