Cert verification for non-CA certs #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking back on this I'm not super convinced this wasn't on purpose. The idea being if you are putting in a specific cert then you're really tying to a key more than a lifecycle. I agree that it's unexpected though so probably we should change this. |
| // We are not looking for trusted chains here since this is a | ||
| // non-CA cert. But validating the connection state detects | ||
| // expired certificates. | ||
| _, err := validateConnState(roots, connState) |
There was a problem hiding this comment.
I think we can just move this check that is happening after this block above the block and avoid the code duplication.
chrishoffman
approved these changes
May 25, 2017
jefferai
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/vault-tool/uVdhJ7DEbYM/pci7UWq-BQAJ