-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: resolves braces < 3.0.3 dep vulnerability and ws < 8.17.1 #27657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jul 1, 2024
Build Results: |
CI Results: |
Monkeychip
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe run enterprise tests locally just in case (if you haven't already).
hellobontempo
added
backport/ent/1.15.x+ent
Changes are backported to 1.15.x+ent
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/1.17.x
labels
Jul 3, 2024
hellobontempo
changed the title
UI: resolves braces < 3.0.3 dep vulnerability
UI: resolves braces < 3.0.3 dep vulnerability and ws < 8.17.1
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/ent/1.15.x+ent
Changes are backported to 1.15.x+ent
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/1.17.x
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a few dependency package updates to address the security vulnerability in
braces v3.0.3
and upgradesws
to8.17.1
. I recommend reviewing by commit, general breakdown of each commit:There was one test failure after upgrading, but the test ran the same before and after the package changes. Closing the modal in the test resolved the issue.
✅ enterprise tests
Backported to 1.15.12+ent, 1.16.6+ent, 1.17.2