Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAULT-28664] Enable the --rerun-fails option in gotestsum for enterprise to reduce the impact of flaky tests on the CI #27695

Merged

Conversation

kubawi
Copy link
Contributor

@kubawi kubawi commented Jul 4, 2024

Description

This PR enables the --rerun-fails option for all Go tests in our enterprise repo. This is to reduce the impact of individual flaky tests on the CI reliability.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

… our enterprise Go test suites to reduce the impact of flaky tests on the CI
@kubawi kubawi requested a review from stevendpclark July 4, 2024 16:47
@kubawi kubawi self-assigned this Jul 4, 2024
@kubawi kubawi requested a review from a team as a code owner July 4, 2024 16:47
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Jul 4, 2024

CI Results:
All Go tests succeeded! ✅

.github/workflows/test-go.yml Outdated Show resolved Hide resolved
@kubawi kubawi requested a review from stevendpclark July 4, 2024 17:13
@kubawi kubawi merged commit 1b794a5 into main Jul 4, 2024
84 checks passed
@kubawi kubawi deleted the kubawi/VAULT-28664/enable-rerun-fails-option-for-go-tests branch July 4, 2024 17:42
@generalsunion
Copy link

kubawi/VAULT-28664/habilitar-opcion-de-reemision-en-casos-de-error-para-pruebas-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x ci hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants