Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: removeember-fetch which used vulnerable version of rollup #28575

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Oct 2, 2024

Description

This is part 1 of resolving the rollup security vulnerability. There is no refactoring necessary because we can just use the native JS fetch method: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch which uses the same syntax

 ⇒ yarn why rollup
├─ broccoli-rollup@npm:2.1.1
│  └─ rollup@npm:0.57.1 (via npm:^0.57.1)
│
├─ broccoli-rollup@npm:4.0.0
│  └─ rollup@npm:1.32.1 (via npm:^1.12.0)
│
└─ broccoli-rollup@npm:5.0.0
   └─ rollup@npm:2.79.1 (via npm:^2.50.0)
⇒ yarn why broccoli-rollup
├─ @ember-data/private-build-infra@npm:4.12.8
│  └─ broccoli-rollup@npm:5.0.0 (via npm:^5.0.0)
│
├─ ember-fetch@npm:8.1.2
│  └─ broccoli-rollup@npm:2.1.1 (via npm:^2.1.1)
│
└─ ember-service-worker@https://github.com/meirish/ember-service-worker.git#commit=dda14187aace0d73ecdb6a55beac2194a3aec01b 
   └─ broccoli-rollup@npm:4.0.0 (via npm:4.0.0)

✅ enterprise tests
Screenshot 2024-10-02 at 3 11 42 PM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.16.11 milestone Oct 2, 2024
@hellobontempo hellobontempo requested a review from a team as a code owner October 2, 2024 22:07
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Oct 2, 2024

CI Results:
All Go tests succeeded! ✅

@@ -5,7 +5,7 @@

import { module, test } from 'qunit';
import { setupRenderingTest } from 'vault/tests/helpers';
import { click, fillIn, render } from '@ember/test-helpers';
import { click, fillIn, render, waitFor, waitUntil } from '@ember/test-helpers';
Copy link
Contributor Author

@hellobontempo hellobontempo Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opted to use these helpers instead of adding helpers like @waitForPromise to the rawRequest functions in production code. Since testing-only helpers should really be avoided in production, if possible! https://www.npmjs.com/package/@ember/test-waiters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's removed from the yarn lock. Did you delete it and rerun it to repopulate? Just curious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! Nope, this was just from uninstalling the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants