Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE: Remove RequestLimiter config plumbing #28592

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Oct 4, 2024

This PR provides some plumbing for the enterprise counterpart PR: hashicorp/vault-enterprise#6791

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

This PR provides some plumbing for the enterprise counterpart PR:
hashicorp/vault-enterprise#6791
@mpalmi mpalmi added this to the 1.18.0 milestone Oct 4, 2024
@mpalmi mpalmi requested review from banks, digivava, davidadeleon and a team October 4, 2024 13:12
@mpalmi mpalmi requested a review from a team as a code owner October 4, 2024 13:12
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Oct 4, 2024

CI Results:
All Go tests succeeded! ✅

@mpalmi mpalmi force-pushed the remove-request-limiter-config branch from 4c1bd31 to dfc5d9c Compare October 4, 2024 13:42
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpalmi mpalmi merged commit 6a145af into main Oct 4, 2024
84 checks passed
@mpalmi mpalmi deleted the remove-request-limiter-config branch October 4, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants