Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Ember upgrade: Handle deprecation router service from host #28603

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Oct 4, 2024

Description

Handles Use alias for inject router service from host application. This PR is based on initial work done by #28281, which I recommend comparing to the changes here.

In summary this PR:

  • replaces router engine dependencies with aliased app-router
  • call the alias @service('app-router') router within engines instead of @service router

Deviations from original PR:

The reason for this is based on the ember guides here:

Screenshot 2024-10-04 at 2 32 21 PM
  • I decided to handle the transition-to slightly differently than the original PR and uninstalled ember-router-helpers and replaced it with a global transition-to helper that uses getOwner to dynamically determine which router to use.
  • Similarly, I refactored LinkedBlock (which is a core component used across engines and the main app) to lookup the appropriate router service via a getter, which felt more stable instead of attempting to inject a service that doesn't exist (which according to above, would throw an error)

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo requested a review from a team as a code owner October 4, 2024 21:38
@hellobontempo hellobontempo added this to the 1.19.0-rc milestone Oct 4, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 4, 2024
@hellobontempo hellobontempo changed the title UI/vault 31211/deprecation router service from host UI: Ember upgrade: Handle deprecation router service from host Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Oct 4, 2024

CI Results: failed ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant