Add approle role name to metadata #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
reviewed
Jul 12, 2017
| @@ -38,6 +38,9 @@ func (b *backend) pathLoginUpdate(req *logical.Request, data *framework.FieldDat | |||
| return logical.ErrorResponse(fmt.Sprintf("failed to validate SecretID: %s", err)), nil | |||
| } | |||
|
|
|||
| // Always include the role name, for later filtering | |||
| metadata["role_name"] = roleName | |||
There was a problem hiding this comment.
How about doing this in path_role.go handleRoleSecretIDCommon when we are persisting the metadata? We might also want to mention in docs that if SecretID metadata is not supplied, by default we add an entry there.
There was a problem hiding this comment.
@vishalnayak one problem with that approach is that existing roles/secret IDs won't have that metadata value persisted unless they're rewritten, whereas this will always work.
vishalnayak
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.