Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for response errors to be passed back from a plugin #3412

Merged
merged 3 commits into from
Oct 6, 2017
Merged

Allow for response errors to be passed back from a plugin #3412

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c07fb1
Allow for response errors to be passed back from a plugin
Oct 3, 2017
961bb5a
Merge remote-tracking branch 'oss/master' into resp-errors
Oct 5, 2017
d8d3e66
Fix issue with checking plugin.BasicError == nil
Oct 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion logical/plugin/backend_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ func (b *backendPluginClient) HandleRequest(req *logical.Request) (*logical.Resp
if reply.Error.Error() == logical.ErrUnsupportedOperation.Error() {
return nil, logical.ErrUnsupportedOperation
}
return nil, reply.Error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might need to do return reply.Response, reply.Error here, and keep the other line to explicitly return nil


return reply.Response, reply.Error
}

return reply.Response, nil
Expand Down