Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move location of quit channel closing in exp manager #3638

Merged
merged 3 commits into from
Dec 1, 2017
Merged

Move location of quit channel closing in exp manager #3638

merged 3 commits into from
Dec 1, 2017

Commits on Dec 1, 2017

  1. Move location of quit channel closing in exp manager 

    If it happens after stopping timers any timers firing before all timers
are stopped will still run the revocation function. With plugin
auto-crash-recovery this could end up instantiating a plugin that could
then try to unwrap a token from a nil token store.

This also plumbs in core so that we can grab a read lock during the
operation and check standby/sealed status before running it (after
grabbing the lock).
    @jefferai
    jefferai committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    109639b View commit details
    Browse the repository at this point in the history

  2. Use context instead of checking core values directly

    @jefferai
    jefferai committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    3c6309b View commit details
    Browse the repository at this point in the history

  3. Use official Go context in a few key places

    @jefferai
    jefferai committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    91b2649 View commit details
    Browse the repository at this point in the history