Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to use multiple paths for capability checking #3663

Merged
merged 8 commits into from
Mar 1, 2018
Merged

Add the ability to use multiple paths for capability checking #3663

merged 8 commits into from
Mar 1, 2018

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Dec 7, 2017 •
edited by vishalnayak
Loading

Fixes #3336

@jefferai jefferai added this to the 0.9.1 milestone Dec 7, 2017
@jefferai jefferai changed the title Add the ability to use multiple paths for capability checking WIP: Add the ability to use multiple paths for capability checking Dec 8, 2017
@jefferai jefferai modified the milestones: 0.9.1, 0.9.2 Dec 18, 2017
@jefferai jefferai modified the milestones: 0.9.2, 0.9.3 Jan 17, 2018
@jefferai jefferai modified the milestones: 0.9.3, 0.9.4 Jan 28, 2018
@vishalnayak vishalnayak changed the title WIP: Add the ability to use multiple paths for capability checking Add the ability to use multiple paths for capability checking Feb 12, 2018
@jefferai jefferai modified the milestones: 0.9.4, 0.10 Feb 14, 2018
@jefferai jefferai modified the milestones: 0.10, 0.9.5 Feb 21, 2018
calvn
calvn reviewed Feb 22, 2018
View reviewed changes
vault/logical_system.go Outdated
}

if len(paths) == 0 {
return nil, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return a "paths not provided" or similar error in this case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. Fixed.

@jefferai jefferai modified the milestones: 0.9.5, 0.9.6 Feb 28, 2018
@jefferai
Copy link
Member Author

@vishalnayak I can't hit Approve on my own PR but I think this LGTM :-) Merge when you like!

@vishalnayak vishalnayak merged commit e7524b8 into master Mar 1, 2018
@vishalnayak vishalnayak deleted the issue-3336 branch March 1, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn left review comments

@vishalnayak vishalnayak vishalnayak left review comments

@briankassouf briankassouf Awaiting requested review from briankassouf

Assignees

@vishalnayak vishalnayak

Labels
None yet
Projects
None yet
Milestone
0.9.6
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @calvn @vishalnayak