Populate AWS-generated tokens with default lease TTL to fix comparisons against role max #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns against role max
kevinwang
approved these changes
Mar 8, 2018
builtin/credential/aws/path_login.go
Outdated
| } | ||
| if resp.Auth.TTL > shortestMaxTTL { | ||
| resp.Auth.TTL = shortestMaxTTL | ||
| resp.AddWarning(fmt.Sprintf("Effective TTL of '%s' exceeded the effective max_ttl of '%s'; TTL value is capped accordingly", (resp.Auth.TTL / time.Second), (shortestMaxTTL / time.Second))) |
There was a problem hiding this comment.
Division by time.Second should be removed here to fix the print statement. ((1 * time.Second) / time.Second evaluates to 1 nanosecond) Same on line 1325.
There was a problem hiding this comment.
We display ttl/max_ttl in seconds to the user...so I think this behavior is actually what we want right?
There was a problem hiding this comment.
When we divide the TTL by time.Second, the print statement looks like this:
* Effective TTL of '2.7648ms' exceeded the effective max_ttl of '600ns'; TTL
value is capped accordingly
With the fix:
* Effective TTL of '768h0m0s' exceeded the effective max_ttl of '10m0s'; TTL
value is capped accordingly
There was a problem hiding this comment.
Ah, ok. That's because we need to print it as a digit, not a string.
vishalnayak
previously approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vishalnayak @kevinwang Can you see if this fixes the problem instead? This won't override the role set TTL (which is allowed to be longer than the system) and is quite a bit simpler.