Allow configuration of dynamodb storage to specify the max retries of aws sdk #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added parameter to set AWS SDK MaxRetries
|
AWS has a default retry value; if the config value isn't set it should use the AWS default, not zero. |
Set the value of the Dynamodb MaxRetries to -1 as the aws sdk uses the default value when that is given as stated in the MaxRetries comments in the following link. https://docs.aws.amazon.com/sdk-for-go/api/aws/#Config
|
I agree. I will update the branch to reflect that. |
jefferai
reviewed
Mar 19, 2018
physical/dynamodb/dynamodb.go
Outdated
| if dynamodbMaxRetryString == "" { | ||
| dynamodbMaxRetryString = conf["dynamodb_max_retries"] | ||
| if dynamodbMaxRetryString == "" { | ||
| dynamodbMaxRetryString = "-1" |
There was a problem hiding this comment.
Please use the aws sdk const name, not the value.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an issue if you are wanting errors to manifest themselves in vault as the errors weren't being shown. By setting the variable to 0 you are able to get error messages from the sdk calls if it fails once and then the clients can handle the retry logic.