Nomad: updating max token length to 256 #4361
Conversation
|
I'm not sure we want to do this yet since most people won't be running Nomad 0.8 for a while. |
|
@jefferai you're right, just leave it here for the future =) |
|
they will pretty soon though, like in the next few weeks :) |
|
I'm targeting this for 0.11 in a few months. But we might need this to be a tunable to merge it, will have to see if the Nomad team has guidance. |
|
if you want I can add the configuration option with the target nomad version |
|
does it matter? isn't it just truncating a key - so if you pass in 64 (nomad <.0.8) it just won't truncate? |
|
Yeah, rather than target Nomad version you'd want to just specify a max length, which can default to 64. At some point we can switch that to default to 256. |
|
I think normal operator doesn't have to know there are those limits, like MySQL plugin(legacy, rds, Maria) |
|
If a normal operator isn't going to touch the settings, it doesn't matter whether they accept a default of "Nomad <0.8" or "64". |
…5117) * Nomad: updating max token length to 256 * Initial support for supporting custom max token name length for Nomad * simplify/correct tests * document nomad max_token_name_length * removed support for max token length env var. Rename field for clarity * cleanups after removing env var support * move RandomWithPrefix to testhelpers * fix spelling * Remove default 256 value. Use zero as a sentinel value and ignore it * update docs
|
Fixed in #5117 |
…p/vault#4361] (#5117) * Nomad: updating max token length to 256 * Initial support for supporting custom max token name length for Nomad * simplify/correct tests * document nomad max_token_name_length * removed support for max token length env var. Rename field for clarity * cleanups after removing env var support * move RandomWithPrefix to testhelpers * fix spelling * Remove default 256 value. Use zero as a sentinel value and ignore it * update docs
…p/vault#4361] (#5117) * Nomad: updating max token length to 256 * Initial support for supporting custom max token name length for Nomad * simplify/correct tests * document nomad max_token_name_length * removed support for max token length env var. Rename field for clarity * cleanups after removing env var support * move RandomWithPrefix to testhelpers * fix spelling * Remove default 256 value. Use zero as a sentinel value and ignore it * update docs
as it's updated in Nomad 0.8
hashicorp/nomad#3888