Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the UI counterpart to #4430 and #4435.
The major change here is replacing calls to
sys/mounts
withsys/internal/ui/mounts
andsys/internal/ui/mounts/:path
- so we no longer need a fetch at the top level secrets route, and when loading individual secrets, we only need to lookup the path for the engine they're trying to view, not the whole list and then filtering for it.The net effect is that we no longer need policy access to
sys/mounts
for the UI to function. As a bonus we also get a list of only the mounts that contain secrets that you have ACLs to operate on.Here's a concrete example: Given a Vault instance with a kv backend mounted at
kv/
, a user logged in with a token policy of only the default policy plus a policy containing:Would see this: