Add num_member_entities and num_parent_groups to key_info in group listing #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
reviewed
May 29, 2018
| @@ -347,7 +347,9 @@ func (i *IdentityStore) pathGroupIDList() framework.OperationFunc { | |||
| group := raw.(*identity.Group) | |||
| groupIDs = append(groupIDs, group.ID) | |||
| groupInfoEntry := map[string]interface{}{ | |||
| "name": group.Name, | |||
| "name": group.Name, | |||
| "num_member_entities": len(group.MemberEntityIDs), | |||
There was a problem hiding this comment.
How about s/num_member_entities/num_member_entity_ids and s/num_member_groups/num_parent_group_ids?
There was a problem hiding this comment.
The IDs aren't members, the entities are members. :-)
There was a problem hiding this comment.
I see what you mean :-) But my thought was to be consistent with the input parameters of the group creation API.
There was a problem hiding this comment.
When doing group creation, you have to provide the IDs because that's how you're referencing the entities. But the entities themselves become members, not the entity IDs.
vishalnayak
previously approved these changes
May 29, 2018
briankassouf
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.