Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hostname instead of the IP when running the actual ssh command with vault ssh #4673

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented Jun 1, 2018

This is implementing the same fix that was added for the CA mode for vault
ssh in #3922
Using the IP address caused Host entries in the ssh_config to not match anymore meaning you would need to hardcode all of your IP addresses in your ssh config instead of using DNS to connect to hosts.

I was originally going to open an issue for this to discuss if it made sense to connect using the hostname instead of IP however I found that this issue already existed and was resolved for the CA backend in #3920 so I decided to just go ahead and commit the code already since this seems to be the way forward.

This is implementing the same fix that was added for the CA mode for vault
ssh in hashicorp#3922
Using the IP address caused `Host` entries in the ssh_config to not
match anymore meaning you would need to hardcode all of your IP
addresses in your ssh config instead of using DNS to connect to hosts
@jefferai jefferai added this to the 0.10.2 milestone Jun 1, 2018
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants