UI - auth method edit #4770
Merged
UI - auth method edit #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisdair
previously approved these changes
Jun 15, 2018
| cli.enter(); | ||
| indexPage.visit({ path }); | ||
| andThen(() => { | ||
| let numTabs = type === 'aws' ? 4 : 2; |
There was a problem hiding this comment.
Looking at the data structure in the helper, it took me a few minutes to figure out why this wasn't ? 3 : 1 instead:
vault/ui/app/helpers/tabs-for-auth-section.js
Lines 67 to 74 in 9b91394
Maybe a comment in the test explaining would help clarify?
meirish
force-pushed
the
ui-auth-mount-edit
branch
from
9b91394
to
6a7d998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some auth methods were erroneously left out of the helper so they wouldn't show up on the edit pages. This fixes that and adds some tests ensuring they're there in the application!
Fixes #4769