-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kv rollback
#4774
Merged
Merged
Add kv rollback
#4774
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,243 @@ | ||
package command | ||
|
||
import ( | ||
"flag" | ||
"fmt" | ||
"strings" | ||
|
||
"github.com/mitchellh/cli" | ||
"github.com/posener/complete" | ||
) | ||
|
||
var _ cli.Command = (*KVRollbackCommand)(nil) | ||
var _ cli.CommandAutocomplete = (*KVRollbackCommand)(nil) | ||
|
||
type KVRollbackCommand struct { | ||
*BaseCommand | ||
|
||
flagVersion int | ||
} | ||
|
||
func (c *KVRollbackCommand) Synopsis() string { | ||
return "Rolls back to a previous version of data" | ||
} | ||
|
||
func (c *KVRollbackCommand) Help() string { | ||
helpText := ` | ||
Usage: vault kv rollback [options] KEY | ||
|
||
*NOTE*: This is only supported for KV v2 engine mounts. | ||
|
||
Restores a given previous version to the current version at the given path. | ||
The value is written as a new version; for instance, if the current version | ||
is 5 and the rollback version is 2, the data from version 2 will become | ||
version 6. | ||
|
||
$ vault kv rollback -version=2 secret/foo | ||
|
||
Additional flags and more advanced use cases are detailed below. | ||
|
||
` + c.Flags().Help() | ||
return strings.TrimSpace(helpText) | ||
} | ||
|
||
func (c *KVRollbackCommand) Flags() *FlagSets { | ||
set := c.flagSet(FlagSetHTTP | FlagSetOutputFormat) | ||
|
||
// Common Options | ||
f := set.NewFlagSet("Common Options") | ||
|
||
f.IntVar(&IntVar{ | ||
Name: "version", | ||
Target: &c.flagVersion, | ||
Usage: `Specifies the version number that should be made current again.`, | ||
}) | ||
|
||
return set | ||
} | ||
|
||
func (c *KVRollbackCommand) AutocompleteArgs() complete.Predictor { | ||
return nil | ||
} | ||
|
||
func (c *KVRollbackCommand) AutocompleteFlags() complete.Flags { | ||
return c.Flags().Completions() | ||
} | ||
|
||
func (c *KVRollbackCommand) Run(args []string) int { | ||
f := c.Flags() | ||
|
||
if err := f.Parse(args); err != nil { | ||
c.UI.Error(err.Error()) | ||
return 1 | ||
} | ||
|
||
var version *int | ||
f.Visit(func(fl *flag.Flag) { | ||
if fl.Name == "version" { | ||
version = &c.flagVersion | ||
} | ||
}) | ||
|
||
args = f.Args() | ||
|
||
switch { | ||
case len(args) != 1: | ||
c.UI.Error(fmt.Sprintf("Invalid number of arguments (expected 1, got %d)", len(args))) | ||
return 1 | ||
case version == nil: | ||
c.UI.Error(fmt.Sprintf("Version flag must be specified")) | ||
return 1 | ||
case c.flagVersion <= 0: | ||
c.UI.Error(fmt.Sprintf("Invalid value %d for the version flag", c.flagVersion)) | ||
return 1 | ||
} | ||
|
||
var err error | ||
path := sanitizePath(args[0]) | ||
|
||
client, err := c.Client() | ||
if err != nil { | ||
c.UI.Error(err.Error()) | ||
return 2 | ||
} | ||
|
||
mountPath, v2, err := isKVv2(path, client) | ||
if err != nil { | ||
c.UI.Error(err.Error()) | ||
return 2 | ||
} | ||
|
||
if !v2 { | ||
c.UI.Error(fmt.Sprintf("K/V engine mount must be version 2 for rollback support")) | ||
return 2 | ||
} | ||
|
||
path = addPrefixToVKVPath(path, mountPath, "data") | ||
if err != nil { | ||
c.UI.Error(err.Error()) | ||
return 2 | ||
} | ||
|
||
// First, do a read to get the current version for check-and-set | ||
var meta map[string]interface{} | ||
{ | ||
secret, err := kvReadRequest(client, path, nil) | ||
if err != nil { | ||
c.UI.Error(fmt.Sprintf("Error doing pre-read at %s: %s", path, err)) | ||
return 2 | ||
} | ||
|
||
// Make sure a value already exists | ||
if secret == nil || secret.Data == nil { | ||
c.UI.Error(fmt.Sprintf("No value found at %s", path)) | ||
return 2 | ||
} | ||
|
||
// Verify metadata found | ||
rawMeta, ok := secret.Data["metadata"] | ||
if !ok || rawMeta == nil { | ||
c.UI.Error(fmt.Sprintf("No metadata found at %s; rollback only works on existing data", path)) | ||
return 2 | ||
} | ||
meta, ok = rawMeta.(map[string]interface{}) | ||
if !ok { | ||
c.UI.Error(fmt.Sprintf("Metadata found at %s is not the expected type (JSON object)", path)) | ||
return 2 | ||
} | ||
if meta == nil { | ||
c.UI.Error(fmt.Sprintf("No metadata found at %s; rollback only works on existing data", path)) | ||
return 2 | ||
} | ||
} | ||
|
||
casVersion := meta["version"] | ||
|
||
// Set the version parameter | ||
versionParam := map[string]string{ | ||
"version": fmt.Sprintf("%d", c.flagVersion), | ||
} | ||
|
||
// Now run it again and read the version we want to roll back to | ||
var data map[string]interface{} | ||
{ | ||
secret, err := kvReadRequest(client, path, versionParam) | ||
if err != nil { | ||
c.UI.Error(fmt.Sprintf("Error doing pre-read at %s: %s", path, err)) | ||
return 2 | ||
} | ||
|
||
// Make sure a value already exists | ||
if secret == nil || secret.Data == nil { | ||
c.UI.Error(fmt.Sprintf("No value found at %s", path)) | ||
return 2 | ||
} | ||
|
||
// Verify metadata found | ||
rawMeta, ok := secret.Data["metadata"] | ||
if !ok || rawMeta == nil { | ||
c.UI.Error(fmt.Sprintf("No metadata found at %s; rollback only works on existing data", path)) | ||
return 2 | ||
} | ||
meta, ok := rawMeta.(map[string]interface{}) | ||
if !ok { | ||
c.UI.Error(fmt.Sprintf("Metadata found at %s is not the expected type (JSON object)", path)) | ||
return 2 | ||
} | ||
if meta == nil { | ||
c.UI.Error(fmt.Sprintf("No metadata found at %s; rollback only works on existing data", path)) | ||
return 2 | ||
} | ||
|
||
// Verify it hasn't been deleted | ||
if meta["deletion_time"] != nil && meta["deletion_time"].(string) != "" { | ||
c.UI.Error(fmt.Sprintf("Cannot roll back to a version that has been deleted")) | ||
return 2 | ||
} | ||
|
||
if meta["destroyed"] != nil && meta["destroyed"].(bool) { | ||
c.UI.Error(fmt.Sprintf("Cannot roll back to a version that has been destroyed")) | ||
return 2 | ||
} | ||
|
||
// Verify old data found | ||
rawData, ok := secret.Data["data"] | ||
if !ok || rawData == nil { | ||
c.UI.Error(fmt.Sprintf("No data found at %s; rollback only works on existing data", path)) | ||
return 2 | ||
} | ||
data, ok = rawData.(map[string]interface{}) | ||
if !ok { | ||
c.UI.Error(fmt.Sprintf("Data found at %s is not the expected type (JSON object)", path)) | ||
return 2 | ||
} | ||
if data == nil { | ||
c.UI.Error(fmt.Sprintf("No data found at %s; rollback only works on existing data", path)) | ||
return 2 | ||
} | ||
} | ||
|
||
secret, err := client.Logical().Write(path, map[string]interface{}{ | ||
"data": data, | ||
"options": map[string]interface{}{ | ||
"cas": casVersion, | ||
}, | ||
}) | ||
if err != nil { | ||
c.UI.Error(fmt.Sprintf("Error writing data to %s: %s", path, err)) | ||
return 2 | ||
} | ||
if secret == nil { | ||
// Don't output anything unless using the "table" format | ||
if Format(c.UI) == "table" { | ||
c.UI.Info(fmt.Sprintf("Success! Data written to: %s", path)) | ||
} | ||
return 0 | ||
} | ||
|
||
if c.flagField != "" { | ||
return PrintRawField(c.UI, secret, c.flagField) | ||
} | ||
|
||
return OutputSecret(c.UI, secret) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never seen this syntax before, do it create a new lexical scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Here it's just for logical separation so I could use the same mechanism but not worry about declaration vs assignment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats a nice trick, the lazy version of a
func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's enough difference that a function having to check parameters would have ended up as long, and quite possibly more complicated.