pki: add ext_key_usage to mirror key_usage and add to sign-verbatim #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Jun 15, 2018
builtin/logical/pki/cert_util.go
Outdated
| @@ -958,7 +968,7 @@ func generateCreationBundle(b *backend, data *dataBundle) error { | |||
| KeyBits: data.role.KeyBits, | |||
| NotAfter: notAfter, | |||
| KeyUsage: x509.KeyUsage(parseKeyUsages(data.role.KeyUsage)), | |||
| ExtKeyUsage: extUsage, | |||
| ExtKeyUsage: extUsage | parseExtKeyUsages(data.role.ExtKeyUsage), | |||
There was a problem hiding this comment.
If you send data.role into parseExtKeyUsages then you can move the logic up above into it so this just becomes ExtKeyUsage: parseExtKeyUsages(data.role).
jefferai
previously approved these changes
Jun 15, 2018
|
Cleaned it up as you suggested 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently was looking at using the vault pki backend to sign CSRs verbatim and found that you could not set the key usage or extended key usage.
This PR adds that ability to sign-verbatim as well as adding the field ext_key_usage to mirror key_usage (and supporting more extended key usages in the process).